RFR: 8341293: Split field loads through Nested Phis [v9]

[Emanuel Peter]

On Tue, 17 Jun 2025 19:19:20 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address CR comments
>
> test/hotspot/jtreg/compiler/c2/irTests/scalarReplacement/AllocationMergesNestedPhiTests.java line 563:
> 
>> 561:     @IR(counts = { IRNode.ALLOC, ">=3" },
>> 562:         phase = CompilePhase.PHASEIDEAL_BEFORE_EA,
>> 563:         applyIfPlatform = {"64-bit", "true"},
> 
> Looks like all tests should be run on 64bit platform? If so perhaps you can just add the requirement at the top of this file, in the annotations section.

@JohnTortugo I'd generally advise against restricting files to limited platforms. The tests can still run on other platforms, and possibly find bugs there. Limiting IR rules allows us to make strong assertions on limited platforms (e.g. asserting that some optimizations are done), while at least testing weaker properties (correctness) on all platforms.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21270#discussion_r2153726516