RFR: 8341293: Split field loads through Nested Phis [v9]

[Cesar Soares Lucas]

On Wed, 18 Jun 2025 06:10:29 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/c2/irTests/scalarReplacement/AllocationMergesNestedPhiTests.java line 563:
>> 
>>> 561:     @IR(counts = { IRNode.ALLOC, ">=3" },
>>> 562:         phase = CompilePhase.PHASEIDEAL_BEFORE_EA,
>>> 563:         applyIfPlatform = {"64-bit", "true"},
>> 
>> Looks like all tests should be run on 64bit platform? If so perhaps you can just add the requirement at the top of this file, in the annotations section.
>
> @JohnTortugo I'd generally advise against restricting files to limited platforms. The tests can still run on other platforms, and possibly find bugs there. Limiting IR rules allows us to make strong assertions on limited platforms (e.g. asserting that some optimizations are done), while at least testing weaker properties (correctness) on all platforms.

I thought the test would not be run if no annotation was applicable to the current platform.
Anyway, if you think this is the best way, that's fine for me too.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21270#discussion_r2155097006