RFR: 8341293: Split field loads through Nested Phis [v9]

Emanuel Peter epeter at openjdk.org
Thu Jun 19 06:12:31 UTC 2025


On Wed, 18 Jun 2025 16:56:47 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:

>> @JohnTortugo I'd generally advise against restricting files to limited platforms. The tests can still run on other platforms, and possibly find bugs there. Limiting IR rules allows us to make strong assertions on limited platforms (e.g. asserting that some optimizations are done), while at least testing weaker properties (correctness) on all platforms.
>
> I thought the test would not be run if no annotation was applicable to the current platform.
> Anyway, if you think this is the best way, that's fine for me too.

@JohnTortugo This is a very important distinction: the IR `applyIf` only restricts the IR rule, not the running of the test itself ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21270#discussion_r2156198216


More information about the hotspot-compiler-dev mailing list