RFR: 8306706: Support out-of-line code generation for MachNodes [v5]
Quan Anh Mai
qamai at openjdk.org
Thu Jun 19 10:32:44 UTC 2025
On Mon, 16 Jun 2025 22:03:04 GMT, Srinivas Vamsi Parasa <sparasa at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>>
>> comments describe C2GeneralStub
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 4339:
>
>> 4337: }
>> 4338:
>> 4339: auto stub = C2CodeStub::make<Register, XMMRegister, address>(dst, src, slowpath_target, 23, convertF2I_slowpath);
>
> Hi @merykitty, could you please explain how the size 23 was computed? This value does not work with APX and I created a PR (https://github.com/openjdk/jdk/pull/25787) for that.
@vamsi-parasa Hi, I just manually assembled the snippet and see its size, for such a small snippet it is easy to see that the size is indeed the largest possible.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13602#discussion_r2156679194
More information about the hotspot-compiler-dev
mailing list