RFR: 8316694: Implement relocation of nmethod within CodeCache [v21]
Chad Rakoczy
duke at openjdk.org
Thu Jun 19 22:27:43 UTC 2025
On Sat, 31 May 2025 10:07:58 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Change to ImmutableDataReferences
>
> src/hotspot/share/code/nmethod.cpp line 1572:
>
>> 1570:
>> 1571: // Verify the nm we copied from is still valid
>> 1572: if (method() != nullptr && method()->code() == this && !is_marked_for_deoptimization() && is_in_use()) {
>
> We can turn `method() != nullptr && method()->code() == this` into an assert. If `is_in_use()` returns true they should be true as well.
I updated this based on your suggestion ([reference](https://github.com/chadrako/jdk/blob/e51a1a09bcee01149fcb4da3e5659e0cad1b2c8b/src/hotspot/share/code/nmethod.cpp#L1575-L1596))
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2157721757
More information about the hotspot-compiler-dev
mailing list