RFR: 8316694: Implement relocation of nmethod within CodeCache [v21]

Chad Rakoczy duke at openjdk.org
Wed Jun 25 19:52:39 UTC 2025


On Sat, 31 May 2025 10:23:09 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:

>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change to ImmutableDataReferences
>
> src/hotspot/share/code/nmethod.hpp line 172:
> 
>> 170:   friend class DeoptimizationScope;
>> 171: 
>> 172:   using ImmutableDataReferences = int;
> 
> Sorry, I might look too annoying. 
> Let's be more specific. This type represents not references themself. It is a counter of them: `ImmutableDataReferenceCounter`
> Let's reflect this in all related names.

I updated the name to `ImmutableDataReferencesCounterSize` ([reference](https://github.com/chadrako/jdk/blob/e51a1a09bcee01149fcb4da3e5659e0cad1b2c8b/src/hotspot/share/code/nmethod.hpp#L172))

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r2167493591


More information about the hotspot-compiler-dev mailing list