RFR: 8360641: TestCompilerCounts fails after 8354727
Martin Doerr
mdoerr at openjdk.org
Mon Jun 30 08:09:39 UTC 2025
On Fri, 27 Jun 2025 18:09:23 GMT, Manuel Hässig <mhaessig at openjdk.org> wrote:
> After integrating #25872 the calculation of the`CICompilerCount` ergonomic became dependent on the size of `NonNMethodCodeHeapSize`, which itself is an ergonomic based on the available memory. Thus, depending on the system, the test `compiler/arguments/TestCompilerCounts.java` failed, i.e. locally this failed, but not on CI servers.
>
> This PR changes the test to reflect the changes introduced in #25872.
>
> Testing:
> - [ ] [Github Actions](https://github.com/mhaessig/jdk/actions/runs/15932906313)
> - [ ] tier1,tier2 plus Oracle internal testing
Thank you for fixing it! I have tested it successfully. Looks good besides what other reviewers have already commented.
test/hotspot/jtreg/compiler/arguments/TestCompilerCounts.java line 186:
> 184: };
> 185: return Math.max(Math.min(count, max_count), min_count);
> 186:
Maybe remove the extra newline?
-------------
PR Review: https://git.openjdk.org/jdk/pull/26024#pullrequestreview-2970286688
PR Review Comment: https://git.openjdk.org/jdk/pull/26024#discussion_r2174473933
More information about the hotspot-compiler-dev
mailing list