RFR: 8360641: TestCompilerCounts fails after 8354727

[Manuel Hässig]

On Mon, 30 Jun 2025 06:47:41 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> After integrating #25872 the calculation of the`CICompilerCount` ergonomic became dependent on the size of `NonNMethodCodeHeapSize`, which itself is an ergonomic based on the available memory. Thus, depending on the system, the test `compiler/arguments/TestCompilerCounts.java` failed, i.e. locally this failed, but not on CI servers.
>> 
>> This PR changes the test to reflect the changes introduced in #25872.
>> 
>> Testing:
>>  - [ ] [Github Actions](https://github.com/mhaessig/jdk/actions/runs/15932906313)
>>  - [ ] tier1,tier2 plus Oracle internal testing
>
> test/hotspot/jtreg/compiler/arguments/TestCompilerCounts.java line 164:
> 
>> 162: 
>> 163:     // Buffer sizes for caclulating the maximum number of compiler threads.
>> 164:     static final int NonNMethodCodeHeapSize = 5 * 1024 * 1024;
> 
> Is the `NonNMethodCodeHeapSize` value chosen "on purpose"?

Not really. We could choose it to be larger. That would just make the cutoff be at a higher CPU count. With 5 MiB, this will also perform a cutoff with less CPUs and should test both code paths on more machines.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26024#discussion_r2174487239