RFR: 8351345: [IR Framework] Improve reported disabled IR verification messages [v3]

[Christian Hagedorn]

On Mon, 10 Mar 2025 18:02:33 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review this trivial patch?
>> Currently, it only reports that some flag is non-whitelisted, but does not print out the flag explicitly, but it's helpful to do so.
>> 
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refine

Looks much better! Two more suggestions, then I think it's good to go :-)

test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 608:

> 606:         // No IR verification is done if additional non-whitelisted JTreg VM or Javaoptions flag is specified.
> 607:         List<String> nonWhiteListedFlags = anyNonWhitelistedJTregVMAndJavaOptsFlags();
> 608:         nonWhiteListedTest = nonWhiteListedFlags.isEmpty();

You can directly add the type declarations here:

boolean debugTest = Platform.isDebugBuild();
boolean intTest = !Platform.isInt();
boolean compTest = !Platform.isComp();
boolean irTest = hasIRAnnotations();

boolean nonWhiteListedTest = nonWhiteListedFlags.isEmpty();

test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 620:

> 618:         }
> 619:         if (!intTest) {
> 620:             System.out.println("- Running with -Xint (use warm-up of 0 instead)");

Suggestion:

            System.out.println("- Running with -Xint (no compilations)");

-------------

PR Review: https://git.openjdk.org/jdk/pull/23931#pullrequestreview-2673168418
PR Review Comment: https://git.openjdk.org/jdk/pull/23931#discussion_r1988573943
PR Review Comment: https://git.openjdk.org/jdk/pull/23931#discussion_r1988574873