RFR: 8351345: [IR Framework] Improve reported disabled IR verification messages [v3]

[Hamlin Li]

On Tue, 11 Mar 2025 07:30:35 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine
>
> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 608:
> 
>> 606:         // No IR verification is done if additional non-whitelisted JTreg VM or Javaoptions flag is specified.
>> 607:         List<String> nonWhiteListedFlags = anyNonWhitelistedJTregVMAndJavaOptsFlags();
>> 608:         nonWhiteListedTest = nonWhiteListedFlags.isEmpty();
> 
> You can directly add the type declarations here:
> 
> boolean debugTest = Platform.isDebugBuild();
> boolean intTest = !Platform.isInt();
> boolean compTest = !Platform.isComp();
> boolean irTest = hasIRAnnotations();
> 
> boolean nonWhiteListedTest = nonWhiteListedFlags.isEmpty();

Yes, fixed.

> test/hotspot/jtreg/compiler/lib/ir_framework/TestFramework.java line 620:
> 
>> 618:         }
>> 619:         if (!intTest) {
>> 620:             System.out.println("- Running with -Xint (use warm-up of 0 instead)");
> 
> Suggestion:
> 
>             System.out.println("- Running with -Xint (no compilations)");

Thanks for the suggestion!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23931#discussion_r1988805712
PR Review Comment: https://git.openjdk.org/jdk/pull/23931#discussion_r1988805876