RFR: 8351861: RISC-V: add simple assert at arrays_equals_v
Fei Yang
fyang at openjdk.org
Thu Mar 13 00:45:55 UTC 2025
On Wed, 12 Mar 2025 14:48:24 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this trivial patch?
>
> `arrays_equals_v` and `arrays_equals` are 2 versions of the same node `AryEqNode`, input `elem_size` should be the same, so should share the same assert of `elem_size`, this also make the code below more clear.
> Although at the same time, we could do the similar thing like https://github.com/openjdk/jdk/pull/24006, but as the code of `arrays_equals_v` and `arrays_equals` seems not require the input must be a byte[] (although in the java level a string's payload is indeed a byte[]), so I'll just leave if as is.
>
> Thanks
Looks fine.
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24008#pullrequestreview-2680170884
More information about the hotspot-compiler-dev
mailing list