RFR: 8351876: RISC-V: enable and fix some float round tests

Fei Yang fyang at openjdk.org
Thu Mar 13 08:24:54 UTC 2025


On Wed, 12 Mar 2025 17:01:14 GMT, Hamlin Li <mli at openjdk.org> wrote:

> Hi,
> Can you help to review this simple patch?
> It's a follow-up of https://github.com/openjdk/jdk/pull/23985.
> 
> Thanks

Looks fine to me modulo one minor comment.

test/hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java line 56:

> 54:       counts = {IRNode.ROUND_VF , " > 0 "})
> 55:   @IR(applyIfPlatform = {"riscv64", "true"},
> 56:       applyIfCPUFeature = {"rvv", "true"},

This `applyIfCPUFeature = {"rvv", "true"},` seems unnecessary? You have already requires `(os.simpleArch == "riscv64" & vm.cpu.features ~= ".*rvv.*")` for this test.

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24015#pullrequestreview-2680925360
PR Review Comment: https://git.openjdk.org/jdk/pull/24015#discussion_r1992998478


More information about the hotspot-compiler-dev mailing list