RFR: 8351876: RISC-V: enable and fix some float round tests

Hamlin Li mli at openjdk.org
Thu Mar 13 08:33:57 UTC 2025


On Thu, 13 Mar 2025 08:21:05 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hi,
>> Can you help to review this simple patch?
>> It's a follow-up of https://github.com/openjdk/jdk/pull/23985.
>> 
>> Thanks
>
> test/hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java line 56:
> 
>> 54:       counts = {IRNode.ROUND_VF , " > 0 "})
>> 55:   @IR(applyIfPlatform = {"riscv64", "true"},
>> 56:       applyIfCPUFeature = {"rvv", "true"},
> 
> This `applyIfCPUFeature = {"rvv", "true"},` seems unnecessary? You have already requires `(os.simpleArch == "riscv64" & vm.cpu.features ~= ".*rvv.*")` for this test.

Yes, it's unnecessary.
But we require `MaxVectorSize >= 32` below, so maybe it's better to keep it for readability.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24015#discussion_r1993014120


More information about the hotspot-compiler-dev mailing list