RFR: 8316694: Implement relocation of nmethod within CodeCache [v4]
Evgeny Astigeevich
eastigeevich at openjdk.org
Mon Mar 17 13:10:02 UTC 2025
On Thu, 13 Mar 2025 21:44:00 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix build issues
>
> test/hotspot/jtreg/compiler/whitebox/RelocateAllNMethods.java line 98:
>
>> 96: import jdk.test.whitebox.WhiteBox;
>> 97:
>> 98: public class RelocateAllNMethods {
>
> Relocate all without destination looks confusing. You need to specify where to relocate nmethods. Also there would be not many compiled code. It mostly tests relocation of code which cannot be relocated.
> IMO it's better to compile a bunch of method, to relocate them, and to execute them.
Please remove the test. We don't need it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23573#discussion_r1998691669
More information about the hotspot-compiler-dev
mailing list