RFR: 8350579: Remove Template Assertion Predicates belonging to a loop once it is folded away [v2]

[Christian Hagedorn]

On Fri, 7 Mar 2025 09:35:19 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Christian Hagedorn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Small things
>>  - Fix test comments
>>  - New approach: Marking unrelated Template Assertion Predicates outside of IGVN by storing a reference to the loop it originally was created for.
>>  - Merge branch 'master' into JDK-8350579
>>  - Revert fix completely
>>  - 8350579: Remove Template Assertion Predicates belonging to a
>>     loop once it is folded away during IGVN
>
> test/hotspot/jtreg/compiler/predicates/assertion/TestAssertionPredicates.java line 105:
> 
>> 103:  * @test id=NoFlags
>> 104:  * @bug 8288981 8350579
>> 105:  * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+AbortVMOnCompilationFailure
> 
> Can you explain why you are enabling `AbortVMOnCompilationFailure`?

I added an additional comment further up in the test to explain the reason.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23823#discussion_r2003439418