RFR: 8350579: Remove Template Assertion Predicates belonging to a loop once it is folded away [v2]

Christian Hagedorn chagedorn at openjdk.org
Wed Mar 19 14:36:31 UTC 2025


On Fri, 7 Mar 2025 09:38:42 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/predicates/assertion/TestAssertionPredicates.java line 159:
>> 
>>> 157: 
>>> 158:     // Runs most of the tests except the really time-consuming ones.
>>> 159:     static void runAllTests() {
>> 
>> Sounds like a bit of a contradiction 😅 
>> 
>> `runAllTests` -> `runAllFastTests`?
>
> Which ones are the really time-consuming ones? And why do you not run them here?

I removed the comment for now - we run all tests here. This only applied to the full test added with JDK-8350577 from which I extracted these bits. I can revisit this comment and method name there again :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23823#discussion_r2003441045


More information about the hotspot-compiler-dev mailing list