RFR: 8350589: Investigate cleaner implementation of AArch64 ML-DSA intrinsic introduced in JDK-8348561 [v5]

[Andrew Dinn]

On Wed, 19 Mar 2025 17:14:08 GMT, Ferenc Rakoczi <duke at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - use references and const to avoid VSeq copying and fix int array arg issue
>>  - fix comment
>>  - fix invalid register argument
>>  - fix errors in comments
>>  - fix whitespace errors
>>  - Clearer implementation of AArch64 dilithium generator
>
> It all looks great to me, the comments are good (a little too verbose for my taste, but they explain well what is happening in the code).

@ferakocz Thanks. I'll integrate this now.
I'll also propose a restructuring of the ML_KEM implementation using VSeq as part of a review of that PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24026#issuecomment-2737470277