RFR: 8351952: [IR Framework]: allow ignoring methods that are not compilable [v4]

Fei Yang fyang at openjdk.org
Fri Mar 21 11:14:23 UTC 2025


On Tue, 18 Mar 2025 10:04:00 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> With the Template Framework, I'm generating IR tests randomly. But random code can always hit bailouts in compilation, and make code not compilable any more. We should have a way to disable this check, and just gracefully continue to execute the tests.
>> 
>> To allow a single test method to be `not compilable`:
>> https://github.com/openjdk/jdk/blob/ce40f1402387f75ea8627883979e3cbf63480941/test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestNotCompilable.java#L160-L161
>> 
>> To allow all test methods to be `not compilable`:
>> https://github.com/openjdk/jdk/blob/ce40f1402387f75ea8627883979e3cbf63480941/test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestNotCompilable.java#L140-L144
>> 
>> See also this documentation in the code:
>> https://github.com/openjdk/jdk/blob/ce40f1402387f75ea8627883979e3cbf63480941/test/hotspot/jtreg/compiler/lib/ir_framework/Test.java#L88-L94
>> 
>> ---------------------------------------
>> 
>> **Background**
>> 
>> My random code seems to hit a bailout in the Register Allocator, and I cannot do much to predict if that bailout happens.
>> See https://bugs.openjdk.org/browse/JDK-8304328
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>

test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestNotCompilable.java line 33:

> 31: /*
> 32:  * @test
> 33:  * @requires vm.compiler2.enabled & vm.flagless

Hi, I wonder if we should add a `vm.debug == true` to the @requires list?
I witnessed test failure on my linux-aarch64 platform with release build when running this test:
 `make test TEST="testlibrary_tests/ir_framework/tests/TestNotCompilable.java"`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24049#discussion_r2007356463


More information about the hotspot-compiler-dev mailing list