RFR: 8351952: [IR Framework]: allow ignoring methods that are not compilable [v4]
Emanuel Peter
epeter at openjdk.org
Fri Mar 21 11:20:22 UTC 2025
On Fri, 21 Mar 2025 11:10:31 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Apply suggestions from code review
>>
>> Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/testlibrary_tests/ir_framework/tests/TestNotCompilable.java line 33:
>
>> 31: /*
>> 32: * @test
>> 33: * @requires vm.compiler2.enabled & vm.flagless
>
> Hi, I wonder if we should add a `vm.debug == true` to the @requires list?
> I witnessed test failure on my linux-aarch64 platform with release build when running this test:
> `make test TEST="testlibrary_tests/ir_framework/tests/TestNotCompilable.java"`
@RealFYang Thanks for the report! I ran full testing, but somehow this slipped though!
java.lang.RuntimeException: should have thrown TestRunException/TestVMException or IRViolationException
at ir_framework.tests.TestNotCompilable.runWithExcludeExpectFailure(TestNotCompilable.java:100)
at ir_framework.tests.TestNotCompilable.runTests(TestNotCompilable.java:58)
at ir_framework.tests.TestNotCompilable.main(TestNotCompilable.java:41)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
at java.base/java.lang.reflect.Method.invoke(Method.java:565)
at com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:335)
at java.base/java.lang.Thread.run(Thread.java:1447)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24049#discussion_r2007365139
More information about the hotspot-compiler-dev
mailing list