RFR: 8352893: C2: OrL/INode::add_ring optimize (x | -1) to -1 [v2]
Tobias Hartmann
thartmann at openjdk.org
Mon Mar 31 14:27:08 UTC 2025
On Mon, 31 Mar 2025 14:02:05 GMT, Manuel Hässig <duke at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/integerArithmetic/TestOrSaturate.java line 47:
>>
>>> 45: @Run(test = {"testL", "testI", "testDelayed"})
>>> 46: public static void check() {
>>> 47: for (int i = 0; i < WARMUP; i++) {
>>
>> Do you actually need the WARMUP here? It does not look like this is a standalone test, so I thought the `@Run` actually gets called many times. Not sure if that is correct...
>
> The name `WARMUP` is not strictly correct, but I left the loop to test more than one value.
As we discussed offline, I think this should use random values instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24289#discussion_r2021154594
More information about the hotspot-compiler-dev
mailing list