RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v59]

Quan Anh Mai qamai at openjdk.org
Fri May 2 16:25:27 UTC 2025


On Fri, 2 May 2025 15:24:40 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add some more sanity static_asserts
>
> src/hotspot/share/opto/rangeinference.cpp line 401:
> 
>> 399:     // In this case, new_lo may not always be a valid answer. This can happen
>> 400:     // if there is no bit upto first_violation that is 0 in both lo and zeros,
>> 401:     // i.e. tmp == 0. In such cases, alignment == 0 && lo == bits._ones. It is
> 
> Suggestion:
> 
>     // i.e. tmp == 0. In such cases, alignment == 0 and new_lo == bits._ones. It is
> 
> Or do we somehow also know that `lo = ones`? I think this was a typo, right?

Yes it is a typo, I changed the wording here, though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2071855272


More information about the hotspot-compiler-dev mailing list