RFR: 8315066: Add unsigned bounds and known bits to TypeInt/Long [v59]
    Quan Anh Mai 
    qamai at openjdk.org
       
    Fri May  2 16:35:29 UTC 2025
    
    
  
On Fri, 2 May 2025 14:04:07 GMT, Emanuel Peter <epeter at openjdk.org> wrote:
>> Quan Anh Mai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add some more sanity static_asserts
>
> src/hotspot/share/opto/compile.cpp line 4505:
> 
>> 4503:   if (sizetype != nullptr && sizetype->_hi > 0) {
>> 4504:     index_max = sizetype->_hi - 1;
>> 4505:   }
> 
> Maybe I asked this before: where does the `sizetype->_hi > 0` come from?
If `sizetype->_hi == 0`, there is no index that can index into this array, so the path is dead. Furthermore, this function really wants a `TypeInt` so this is the cleanest fix for me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17508#discussion_r2071867519
    
    
More information about the hotspot-compiler-dev
mailing list