RFR: 8352869: Verify.checkEQ: extension for NaN, VectorAPI and arbitrary Objects [v13]

[Tobias Hartmann]

On Mon, 7 Apr 2025 06:08:55 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> We should extend the functionality of Verify.checkEQ:
>> - Allow different NaN encodings to be seen as equal (by default).
>> - Compare VectorAPI vectors.
>> - Compare Exceptions, and their messages.
>> - Compare arbitrary Objects via Reflection.
>> 
>> Note: this is a prerequisite for the Template Library [JDK-8352861](https://bugs.openjdk.org/browse/JDK-8352861) / https://github.com/openjdk/jdk/pull/23418.
>
> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>

Looks good to me! I just found a few minor typos.

test/hotspot/jtreg/compiler/lib/verify/Verify.java line 35:

> 33: 
> 34: /**
> 35:  * The {@link Verify} class provide {@link Verify#checkEQ} and {@link Verify#checkEQWithRawBits},

Suggestion:

 * The {@link Verify} class provides {@link Verify#checkEQ} and {@link Verify#checkEQWithRawBits},

test/hotspot/jtreg/compiler/lib/verify/Verify.java line 36:

> 34: /**
> 35:  * The {@link Verify} class provide {@link Verify#checkEQ} and {@link Verify#checkEQWithRawBits},
> 36:  * which recursively compare the two  {@link Object}s by value. They deconstruct an array of objects,

Suggestion:

 * which recursively compare the two {@link Object}s by value. They deconstruct an array of objects,

test/hotspot/jtreg/compiler/lib/verify/Verify.java line 38:

> 36:  * which recursively compare the two  {@link Object}s by value. They deconstruct an array of objects,
> 37:  * compare boxed primitive types, compare the content of arrays and {@link MemorySegment}s, and check
> 38:  * that the messages of two {@link Exception}s are equal. They also checks for the equivalent content

Suggestion:

 * that the messages of two {@link Exception}s are equal. They also check for the equivalent content

test/hotspot/jtreg/compiler/lib/verify/Verify.java line 486:

> 484:     }
> 485: 
> 486: 

Suggestion:

-------------

Marked as reviewed by thartmann (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24224#pullrequestreview-2814621188
PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2073336816
PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2073337119
PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2073339500
PR Review Comment: https://git.openjdk.org/jdk/pull/24224#discussion_r2073354421