RFR: 8347515: C2: assert(!success || (C->macro_count() == (old_macro_count - 1))) failed: elimination must have deleted one node from macro list [v4]

[Tobias Hartmann]

On Thu, 8 May 2025 08:13:46 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressing review comments
>
> src/hotspot/share/opto/macro.cpp line 2353:
> 
>> 2351: }
>> 2352: 
>> 2353: //------------------refine_strip_mined_loop_macro_node-------------------
> 
> Those headers were used in legacy code and you still see quite some of them around. But nowadays, we usually remove them when touching these methods or at least we don't add them for new methods.
> 
> Suggestion:

I agree, please remove this header.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24890#discussion_r2079555444