RFR: 8347515: C2: assert(!success || (C->macro_count() == (old_macro_count - 1))) failed: elimination must have deleted one node from macro list [v4]

[Saranya Natarajan]

On Thu, 8 May 2025 11:44:09 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> src/hotspot/share/opto/macro.cpp line 2353:
>> 
>>> 2351: }
>>> 2352: 
>>> 2353: //------------------refine_strip_mined_loop_macro_node-------------------
>> 
>> Those headers were used in legacy code and you still see quite some of them around. But nowadays, we usually remove them when touching these methods or at least we don't add them for new methods.
>> 
>> Suggestion:
>
> I agree, please remove this header.

Sorry, I missed this comment. I have fixed this in the latest commit.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24890#discussion_r2079611868