RFR: 8356192: Enable AOT code caching only on supported platforms [v2]
Aleksey Shipilev
shade at openjdk.org
Mon May 12 13:01:53 UTC 2025
On Mon, 12 May 2025 12:56:07 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Vladimir Kozlov has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Limit platforms to run AOTCode test
>
> src/hotspot/share/code/aotCodeCache.cpp line 92:
>
>> 90:
>> 91: void AOTCodeCache::initialize() {
>> 92: #if !(defined(AMD64) || defined(AARCH64))
>
> Sounds like we need to also take care about Zero? E.g. `defined(ZERO) || (!defined(AMD64) && !defined(AARCH64))`?
Or invert it and put it at `else`, reads better and matches other blocks around Hotspot.
#if !defined(ZERO) && (defined(AMD64) || defined(AARCH64))
...
#else
log_info(aot, codecache, init)("AOT Code Cache is not supported on this platform.");
AOTAdapterCaching = false;
return;
#endif
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25158#discussion_r2084619766
More information about the hotspot-compiler-dev
mailing list