RFR: 8356192: Enable AOT code caching only on supported platforms [v2]
Vladimir Kozlov
kvn at openjdk.org
Mon May 12 15:54:51 UTC 2025
On Mon, 12 May 2025 12:58:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> src/hotspot/share/code/aotCodeCache.cpp line 92:
>>
>>> 90:
>>> 91: void AOTCodeCache::initialize() {
>>> 92: #if !(defined(AMD64) || defined(AARCH64))
>>
>> Sounds like we need to also take care about Zero? E.g. `defined(ZERO) || (!defined(AMD64) && !defined(AARCH64))`?
>
> Or invert it and put it at `else`, reads better and matches other blocks around Hotspot.
>
>
> #if !defined(ZERO) && (defined(AMD64) || defined(AARCH64))
> ...
> #else
> log_info(aot, codecache, init)("AOT Code Cache is not supported on this platform.");
> AOTAdapterCaching = false;
> return;
> #endif
Right. Do we have check for Zero in tests?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25158#discussion_r2084987757
More information about the hotspot-compiler-dev
mailing list