RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v7]
Daniel Lundén
dlunden at openjdk.org
Thu May 15 12:42:56 UTC 2025
On Tue, 29 Apr 2025 04:58:39 GMT, Galder Zamarreño <galder at openjdk.org> wrote:
>> Daniel Lundén has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update after comments from Christian
>
> src/hotspot/share/opto/gcm.cpp line 889:
>
>> 887: // since the load will be forced into a block preceding the Phi.
>> 888: pred_block->set_raise_LCA_mark(load_index);
>> 889: assert(!LCA_orig->dominates(pred_block) ||
>
> Has this assert moved elsewhere? Or do we really want to remove it altogether?
Resolving this now, hopefully I've answered your question @galderz!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2091081640
More information about the hotspot-compiler-dev
mailing list