RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v7]

[Daniel Lundén]

On Wed, 30 Apr 2025 09:48:39 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:

>> src/hotspot/share/opto/gcm.cpp line 912:
>> 
>>> 910:         // they CAN write to Java memory.
>>> 911:         if (muse->ideal_Opcode() == Op_CallStaticJava) {
>>> 912:           assert(muse->is_MachSafePoint(), "");
>> 
>> I know there was not assert message before, but can we use the opportunity to add a meaningful message for this assert? There's another empty message assert a few lines before.
>
> Thanks for the comments @galderz! I do not know the specifics of this particular part of `insert_anti_dependences`. I could add generic assert messages, based on the checks, for the purpose of avoiding empty messages. But I'm not sure those are then meaningful messages.

Resolving this as well now; I cannot add assert messages that provide more information than the checks themselves. Let's leave any changes for a future RFE.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2091095671