RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v7]

[Daniel Lundén]

On Wed, 7 May 2025 09:28:37 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:

>> Thanks @TobiHartmann. Note that this changeset does remove the assert, and replaces it with another (stronger, in theory) assert.
>
> Ah right, I missed that.

@robcasloz suggested that I simply add the new assert to the commit just before the fix which `test4` is a regression test for (much simpler than trying to revert the fix in mainline), and check if it triggers when the old assert triggers. When I manually disable loop strip mining verification (as Tobias suggested), the new assert triggers, as expected, whenever the old assert triggers. Resolving this thread now!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2091078123