RFR: 8351568: Improve source code documentation for PhaseCFG::insert_anti_dependences [v7]
Tobias Hartmann
thartmann at openjdk.org
Fri May 16 10:48:02 UTC 2025
On Thu, 15 May 2025 12:38:26 GMT, Daniel Lundén <dlunden at openjdk.org> wrote:
>> Ah right, I missed that.
>
> @robcasloz suggested that I simply add the new assert to the commit just before the fix which `test4` is a regression test for (much simpler than trying to revert the fix in mainline), and check if it triggers when the old assert triggers. When I manually disable loop strip mining verification (as Tobias suggested), the new assert triggers, as expected, whenever the old assert triggers. Resolving this thread now!
Great, thanks for double checking!
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24926#discussion_r2092812813
More information about the hotspot-compiler-dev
mailing list