RFR: 8344942: Template-Based Testing Framework [v30]

[Emanuel Peter]

On Fri, 16 May 2025 09:09:07 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   apply offline suggestions by Christian
>
> Some first comments for `Template`, will continue with the other files :-)
> 
> And thanks for bearing with us! I'm also very happy about the naming and design we found together. It was well worth to discuss everything more in-depth. The result is very good now I think! :-)

@chhagedorn I applied all your suggestions. Let's discuss offline about what additional tutorial / tests you would like to have for the `Name`s.

> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 675:
> 
>> 673:      * @return The token that performs the defining action.
>> 674:      */
>> 675:     static Token addName(Name name) {
> 
> I have not fully grasped the concept of these `Name`s, yet. The `generateWithNames()` example in `TestTutorial` is quite big and complex. Could you add there a simpler example to better understand this idea of names?

Let's discuss offline to see what would be good to have here.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24217#issuecomment-2886296861
PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2092770855