RFR: 8344942: Template-Based Testing Framework [v40]

[Emanuel Peter]

On Tue, 20 May 2025 09:48:19 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Offline review
>
> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 184:
> 
>> 182:  * template can be changed when we {@code render()} it (e.g. {@link ZeroArgs#render(float)}) and the default
>> 183:  * fuel cost with {@link #setFuelCost}) when defining the {@link #body(Object...)}. Recursive templates are
>> 184:  * supposed to terminate once the {@link #fuel} is depleted (i.e. reaches zero).
> 
> This sentence is a bit vague, maybe you could state explicitly who is responsible for ensuring termination (e.g. "Once the {@link #fuel} is depleted (i.e. reaches zero), the writer of a recursive template should ensure ...").

I updated the section a little. I hope it is better now?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2098326231