RFR: 8344942: Template-Based Testing Framework [v40]

[Roberto Castañeda Lozano]

On Tue, 20 May 2025 15:52:11 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> test/hotspot/jtreg/compiler/lib/template_framework/Template.java line 184:
>> 
>>> 182:  * template can be changed when we {@code render()} it (e.g. {@link ZeroArgs#render(float)}) and the default
>>> 183:  * fuel cost with {@link #setFuelCost}) when defining the {@link #body(Object...)}. Recursive templates are
>>> 184:  * supposed to terminate once the {@link #fuel} is depleted (i.e. reaches zero).
>> 
>> This sentence is a bit vague, maybe you could state explicitly who is responsible for ensuring termination (e.g. "Once the {@link #fuel} is depleted (i.e. reaches zero), the writer of a recursive template should ensure ...").
>
> I updated the section a little. I hope it is better now?

Yes, thanks! For better readability, I suggest merging the paragraph ending with "With the indirection of such a binding, a Template can reference itself." and the paragraph starting with "The writer of recursive {@link Template}s must ensure that this recursion terminates" into a single paragraph.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24217#discussion_r2098476090