RFR: 8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter [v2]

Christian Hagedorn chagedorn at openjdk.org
Fri May 23 08:46:56 UTC 2025


On Fri, 23 May 2025 07:57:39 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Interesting! You're right. I haven't checked the testing results, yet. Should we just change to `Null` or make an exclusion in `TestNoNULL`?
>
> I don't think this should be given an exclusion in TestNoNULL.
> 
> If the printed name is supposed to be related to the compiler object `TypePtr::Null` then I suggest it should
> be "Null".  If it's supposed to be related to the Java null value, then "null" seems appropriate.  And in the
> diagram in the PR intro I see things printed as "NotNull" which might argue for "Null".

I guess `Null` is fine then. I only chose `NULL` to be in line with the other capitalized letters shown in IGV in the condensed view.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25393#discussion_r2104122586


More information about the hotspot-compiler-dev mailing list