RFR: 8357568: IGV: Show NULL and numbers up to 4 characters in "Condense graph" filter [v2]
Kim Barrett
kbarrett at openjdk.org
Fri May 23 08:01:56 UTC 2025
On Fri, 23 May 2025 07:35:00 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:
>> Actually it does, see failures in github actions testing:
>>> Failed. Execution failed: `main' threw exception: java.lang.RuntimeException: Test found 1 usages of 'NULL' in source files. See errors above.
>
> Interesting! You're right. I haven't checked the testing results, yet. Should we just change to `Null` or make an exclusion in `TestNoNULL`?
I don't think this should be given an exclusion in TestNoNULL.
If the printed name is supposed to be related to the compiler object `TypePtr::Null` then I suggest it should
be "Null". If it's supposed to be related to the Java null value, then "null" seems appropriate. And in the
diagram in the PR intro I see things printed as "NotNull" which might argue for "Null".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25393#discussion_r2104038585
More information about the hotspot-compiler-dev
mailing list