RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v11]

Christian Hagedorn chagedorn at openjdk.org
Wed Nov 5 11:52:33 UTC 2025


On Wed, 5 Nov 2025 10:15:33 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   small adjustments after call with Roberto and Christian
>
> test/hotspot/jtreg/testlibrary_tests/template_framework/tests/TestTemplate.java line 1259:
> 
>> 1257:             let("global", "GLOBAL"),
>> 1258:             "g: #global. $a\n",
>> 1259:             // Create a dummy DataName soe we can create the scope.
> 
> Suggestion:
> 
>             // Create a dummy DataName so we can create the scope.

Is a dummy DataName required or could you also just write `scope(...)`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2493836170


More information about the hotspot-compiler-dev mailing list