RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v11]

Emanuel Peter epeter at openjdk.org
Wed Nov 5 12:51:22 UTC 2025


On Wed, 5 Nov 2025 10:17:21 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> test/hotspot/jtreg/testlibrary_tests/template_framework/tests/TestTemplate.java line 1259:
>> 
>>> 1257:             let("global", "GLOBAL"),
>>> 1258:             "g: #global. $a\n",
>>> 1259:             // Create a dummy DataName soe we can create the scope.
>> 
>> Suggestion:
>> 
>>             // Create a dummy DataName so we can create the scope.
>
> Is a dummy DataName required or could you also just write `scope(...)`?

We want to do `sample`. If there is no `addDataName` before, we will get an exception. I changed the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2494309370


More information about the hotspot-compiler-dev mailing list