RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v14]

[Emanuel Peter]

On Thu, 6 Nov 2025 07:32:59 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - for Christian
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/template_framework/Renderer.java line 88:
> 
>> 86:      *
>> 87:      * <p>
>> 88:      * Instead, the user should create a {@link TemplateToken} from the inner {@link Template}, and
> 
> Read this through again to refresh my memory an noticed this: "Should" sounds like good advise but below it clearly mention it's forbidden. Would it make sense to swap the paragraphs? Then it makes it more clear that this is not only advise but the only way to go.

Sounds good, `should` -> `must`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2498778002