RFR: 8367531: Template Framework: use scopes and tokens instead of misbehaving immediate-return-queries [v14]

Emanuel Peter epeter at openjdk.org
Thu Nov 6 12:40:17 UTC 2025


On Thu, 6 Nov 2025 08:41:01 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Emanuel Peter has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - for Christian
>>  - Apply suggestions from code review
>>    
>>    Co-authored-by: Christian Hagedorn <christian.hagedorn at oracle.com>
>
> test/hotspot/jtreg/compiler/lib/template_framework/Renderer.java line 145:
> 
>> 143:         // Ensure CodeFrame consistency.
>> 144:         if (baseCodeFrame != currentCodeFrame) {
>> 145:             throw new RuntimeException("Internal error: Renderer did not end up at base CodeFrame.");
> 
> Optionally, something for another RFE (there are more "Internal error message"): You could turn these runtime exception into `TemplateFrameworkException`s add a hint to report a bug.

Sure, let me file an RFE :)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27255#discussion_r2498801254


More information about the hotspot-compiler-dev mailing list