RFR: 8349835: C2: simplify IGV property printing [v2]
Christian Hagedorn
chagedorn at openjdk.org
Wed Nov 12 07:43:05 UTC 2025
On Mon, 27 Oct 2025 22:07:21 GMT, Saranya Natarajan <snatarajan at openjdk.org> wrote:
>> src/hotspot/share/opto/idealGraphPrinter.hpp line 172:
>>
>>> 170: };
>>> 171:
>>> 172: class PrintProperties
>>
>> Do you really need it in the header file? You could also just move it the the source file directly where we use the class.
>
> My reasoning is keep the interface and implementation separate. I have kept it this way. Will that be okay ?
I'm not sure I understand the benefit of having it separately when the only user is in the source file and it's tightly coupled to the implementation of the `IdealGraphPrinter` class. This will expose it to other files while it's not needed. Or is it just for readability?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26902#discussion_r2517247669
More information about the hotspot-compiler-dev
mailing list