RFR: 8349835: C2: simplify IGV property printing [v2]

Saranya Natarajan snatarajan at openjdk.org
Mon Nov 17 10:21:37 UTC 2025


On Wed, 12 Nov 2025 07:40:30 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> My reasoning is keep the interface and implementation separate. I have kept it this way. Will that be okay ?
>
> I'm not sure I understand the benefit of having it separately when the only user is in the source file and it's tightly coupled to the implementation of the `IdealGraphPrinter` class. This will expose it to other files while it's not needed. Or is it just for readability?

Yes, it was mostly for readability. I do agree with you and have now followed your suggestion of moving the class to the source file.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26902#discussion_r2533502542


More information about the hotspot-compiler-dev mailing list