RFR: 8356761: IGV: dump escape analysis information [v3]

[Anton Seoane Ampudia]

On Thu, 13 Nov 2025 08:22:42 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Anton Seoane Ampudia has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - Review comments: remove spurious new line
>>  - Review comments: update header
>>    
>>    Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>>  - Review comments: AddP misspell
>>    
>>    Co-authored-by: Roberto Castañeda Lozano <robcasloz at users.noreply.github.com>
>
> src/hotspot/share/opto/escape.cpp line 2515:
> 
>> 2513: bool ConnectionGraph::find_non_escaped_objects(GrowableArray<PointsToNode*>& ptnodes_worklist,
>> 2514:                                                GrowableArray<JavaObjectNode*>& non_escaped_allocs_worklist,
>> 2515:                                                bool verify) {
> 
> `verify` suggests to actually do some verification. But it seems like it's only a toggle for dumping a graph. Could we rename it to `dump_for_igv` or something like that?

`find_non_escaped_objects` runs twice, with the second time as verification phase only. I thought adding it this way would be explicit at the caller site about if we are doing verification. Changing it to `dump_to_igv` is trivial though, so let me know if you feel it's still clearer that way and I'll change it quickly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28060#discussion_r2522764620