RFR: 8356761: IGV: dump escape analysis information [v3]

[Christian Hagedorn]

On Thu, 13 Nov 2025 10:14:49 GMT, Anton Seoane Ampudia <aseoane at openjdk.org> wrote:

>> src/hotspot/share/opto/escape.cpp line 2515:
>> 
>>> 2513: bool ConnectionGraph::find_non_escaped_objects(GrowableArray<PointsToNode*>& ptnodes_worklist,
>>> 2514:                                                GrowableArray<JavaObjectNode*>& non_escaped_allocs_worklist,
>>> 2515:                                                bool verify) {
>> 
>> `verify` suggests to actually do some verification. But it seems like it's only a toggle for dumping a graph. Could we rename it to `dump_for_igv` or something like that?
>
> `find_non_escaped_objects` runs twice, with the second time as verification phase only. I thought adding it this way would be explicit at the caller site about if we are doing verification. Changing it to `dump_to_igv` is trivial though, so let me know if you feel it's still clearer that way and I'll change it quickly.

I see, I looked at it from the callee-side which makes it suggest to perform some verification which it does not. Maybe @robcasloz can break the tie here :-)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28060#discussion_r2523167925