RFR: 8356761: IGV: dump escape analysis information [v3]

Roberto Castañeda Lozano rcastanedalo at openjdk.org
Thu Nov 13 12:05:18 UTC 2025


On Thu, 13 Nov 2025 11:50:58 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> `find_non_escaped_objects` runs twice, with the second time as verification phase only. I thought adding it this way would be explicit at the caller site about if we are doing verification. Changing it to `dump_to_igv` is trivial though, so let me know if you feel it's still clearer that way and I'll change it quickly.
>
> I see, I looked at it from the callee-side which makes it suggest to perform some verification which it does not. Maybe @robcasloz can break the tie here :-)

No strong opinions here, but if you ask me anyway I tend to agree with Christian that it would be a bit clearer to name the predicate for the effect it has. May I suggest to call it `print_method` in that case? (since `Compile::print_method` does more than IGV dumping).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28060#discussion_r2523200269


More information about the hotspot-compiler-dev mailing list