RFR: 8349835: C2: Simplify IGV property printing [v8]

Damon Fenacci dfenacci at openjdk.org
Fri Nov 21 10:21:00 UTC 2025


On Thu, 20 Nov 2025 20:57:42 GMT, Saranya Natarajan <snatarajan at openjdk.org> wrote:

>> The code that prints node properties and live range properties is very verbose and repetitive and could be simplified by applying a refactoring suggested [here](https://github.com/openjdk/jdk/pull/23558#discussion_r1950785708).
>> 
>> ### Fix 
>> Implemented the suggested refactoring. 
>> 
>> ### Testing 
>> Github Actions, Tier 1-3
>
> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix for merge mistake

Thanks again @sarannat. I just have one more nit/doubt. Looks good to me otherwise.

src/hotspot/share/opto/idealGraphPrinter.cpp line 80:

> 78:   print_property(true, "mask", buffer);
> 79:   print_property(true, "mask_size", lrg.mask_size());
> 80:   if (lrg._degree_valid) {

I know it was there already, but do we still need this if?

-------------

Marked as reviewed by dfenacci (Committer).

PR Review: https://git.openjdk.org/jdk/pull/26902#pullrequestreview-3492074926
PR Review Comment: https://git.openjdk.org/jdk/pull/26902#discussion_r2549251366


More information about the hotspot-compiler-dev mailing list