RFR: 8349835: C2: Simplify IGV property printing [v8]
Saranya Natarajan
snatarajan at openjdk.org
Fri Nov 21 10:44:28 UTC 2025
On Fri, 21 Nov 2025 10:16:23 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:
>> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
>>
>> fix for merge mistake
>
> src/hotspot/share/opto/idealGraphPrinter.cpp line 80:
>
>> 78: print_property(true, "mask", buffer);
>> 79: print_property(true, "mask_size", lrg.mask_size());
>> 80: if (lrg._degree_valid) {
>
> I know it was there already, but do we still need this if?
When I did the testing as suggested by @robcasloz, I noticed that without the` if (lrg._degree_valid)`, the call to `lrg.degree()` crashes when` lrg._degree_valid` is not true.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26902#discussion_r2549326750
More information about the hotspot-compiler-dev
mailing list