RFR: 8370489: Some compiler tests miss the @key randomness [v2]

Saranya Natarajan snatarajan at openjdk.org
Wed Nov 26 11:24:21 UTC 2025


On Mon, 24 Nov 2025 07:32:12 GMT, Damon Fenacci <dfenacci at openjdk.org> wrote:

>> Saranya Natarajan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   addressing review comments - removing space and javadoc style
>
> test/hotspot/jtreg/compiler/vectorapi/Test8278948.java line 33:
> 
>> 31: import jdk.test.lib.Utils;
>> 32: 
>> 33: /**
> 
> Do we need javadoc style comments for JTreg? (we don't seem to be too consistent in our tests)

That is true. There is no need for javadoc style comments  (see [The JDK Test Framework: Tag Language Specification](https://openjdk.org/jtreg/tag-spec.html)). I have fixed this file.

You are also right about we not being consistent with the tests. I have left the rest of the test (in this changeset) with javadoc style as it is. Do let me know if I should change them ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28463#discussion_r2564592720


More information about the hotspot-compiler-dev mailing list