RFR: 8370489: Some compiler tests miss the @key randomness [v2]
Emanuel Peter
epeter at openjdk.org
Wed Nov 26 11:29:48 UTC 2025
On Wed, 26 Nov 2025 11:20:40 GMT, Saranya Natarajan <snatarajan at openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/vectorapi/Test8278948.java line 33:
>>
>>> 31: import jdk.test.lib.Utils;
>>> 32:
>>> 33: /**
>>
>> Do we need javadoc style comments for JTreg? (we don't seem to be too consistent in our tests)
>
> That is true. There is no need for javadoc style comments (see [The JDK Test Framework: Tag Language Specification](https://openjdk.org/jtreg/tag-spec.html)). I have fixed this file.
>
> You are also right about we not being consistent with the tests. I have left the rest of the test (in this changeset) with javadoc style as it is. Do let me know if I should change them ?
Personally, I would not worry too much about comment style. Well actually: are we sure that both get executed?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28463#discussion_r2564612087
More information about the hotspot-compiler-dev
mailing list