RFR: 8370489: Some compiler tests miss the @key randomness [v2]

Saranya Natarajan snatarajan at openjdk.org
Thu Nov 27 10:24:58 UTC 2025


On Wed, 26 Nov 2025 11:27:19 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> That is true. There is no need for javadoc style comments  (see [The JDK Test Framework: Tag Language Specification](https://openjdk.org/jtreg/tag-spec.html)). I have fixed this file.
>> 
>> You are also right about we not being consistent with the tests. I have left the rest of the test (in this changeset) with javadoc style as it is. Do let me know if I should change them ?
>
> Personally, I would not worry too much about comment style. Well actually: are we sure that both get executed?

I tested the following tests in this changeset that started with` /**` (javadoc style) with` /**` and` /*`. Both the styles resulted in the same results. 
test/hotspot/jtreg/compiler/intrinsics/float16/TestFloat16MaxMinSpecialValues.java
test/hotspot/jtreg/compiler/loopopts/parallel_iv/TestParallelIvInIntCountedLoop.java
test/hotspot/jtreg/compiler/loopopts/superword/MinMaxRed_Int.java
test/hotspot/jtreg/compiler/c2/aarch64/TestFloat16Replicate.java
test/hotspot/jtreg/compiler/vectorapi/TestVectorAddMulReduction.java
test/hotspot/jtreg/compiler/vectorapi/TestVectorCompressExpandBits.java
test/hotspot/jtreg/compiler/vectorapi/VectorMultiplyOpt.java
test/hotspot/jtreg/compiler/vectorapi/VectorSaturatedOperationsTest.java
test/hotspot/jtreg/compiler/vectorization/TestMacroLogicVector.java

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28463#discussion_r2567943579


More information about the hotspot-compiler-dev mailing list